Improve get SDK version values on Android #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorbenprimke
approved these changes
Sep 17, 2018
templates/android.js
Outdated
| def safeExtGet(prop, fallback) { | ||
| rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback | ||
| } | ||
|
|
||
| def DEFAULT_COMPILE_SDK_VERSION = 27 | ||
| def DEFAULT_BUILD_TOOLS_VERSION = "27.0.3" | ||
| def DEFAULT_MIN_SDK_VERSION = 16 | ||
| def DEFAULT_TARGET_SDK_VERSION = 26 |
There was a problem hiding this comment.
Yes, bump this to 27.
Compile and target should match afaik.
thebylito
pushed a commit
to thebylito/react-native-create-library
that referenced
this pull request
Apr 24, 2019
* Improve get SDK version values on Android * Target to compile should match
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #67 just a bit of cleanup.
@thorbenprimke You think it's fine to also update the version to 27?