Provide API that includes printf specifier arities along with ranges

[latkin]

Motivation: fsprojects-archive/zzarchive-VisualFSharpPowerTools#1335

Tools that wish to map from specifier->argument(s) or vice versa need to know not only the range of the specifier, but also its arity. Most usages involve only 1 argument per specifier, but there are special cases with * width and/or precision slots, or the %a specifier, which add additional arguments.

Closely related - %%/%*%/%*.*% will now be reported as a format specifiers (with arity 0/1/2).

[dsyme]

Please add Obsolete to this, with a message to use the new method

[dsyme]

Great work!

There's a test failure, suspect it won't be too hard to fix

[00:17:36] 1) Test Failure : FSharp.Compiler.Service.Tests.Editor.Printf specifiers for regular and verbatim strings
[00:17:36]      Expected: [||]
[00:17:36] Actual: [|/home/user/Test.fsx (33,45)-(33,47) typecheck error This expression was expected to have type
[00:17:36]     string    
[00:17:36] but here has type
[00:17:36]     unit    ;
[00:17:36]   /home/user/Test.fsx (34,49)-(34,51) typecheck error This expression was expected to have type
[00:17:36]     string    
[00:17:36] but here has type
[00:17:36]     unit    |]
[00:17:36]   Expected is <Microsoft.FSharp.Compiler.FSharpErrorInfo[0]>, actual is <Microsoft.FSharp.Compiler.FSharpErrorInfo[2]>
[00:17:36]   Values differ at index [0]
[00:17:36]   Extra:    < </home/user/Test.fsx (33,45)-(33,47) typecheck error This expression was expected to have type
[00:17:36]     string    
[00:17:36] but here has type
[00:17:36]     unit    >, </home/user/Test.fsx (34,49)-(34,51) typecheck error This expression was expected to have type
[00:17:36]     string    
[00:17:36] but here has type
[00:17:36]     unit    > >
[00:17:36] at FSharp.Compiler.Service.Tests.Editor.Printf specifiers for regular and v
[00:17:36] erbatim strings() in C:\projects\fsharp-compiler-service\tests\service\EditorTests.fs:line 407

[latkin]

Whoops, thanks. All should be good now.

[dsyme]

@rneatherway Would you be able to push a new nuget package?

@latkin Would you like to have publish-the-package rights? There's no one better qualified :)

[latkin]

Sure, I'd be honored

[dsyme]

@latkin OK you have invitations to Write access to this repo and to the two nuget package repos.

Think that's all you need to publish. I find the build.fsx publishing process can go wrong sometimes in different repos. It seems best to build+test the nupkg and push it manually, and then do GenerateDocs and ReleaseDocs carefully too. On occasion in different repos ReleaseDocs has nuked the whole contents of the github-pages branch, requiring a forced push or two.

[rneatherway]

That is great if someone who uses Windows can do the releases. I never managed to create a single Windows installation where the tests passed and the SourceLink stuff worked.

[latkin]

FWIW tests don't pass on my machine, either.

[dsyme]

Tests pass on mine, at least last time I checked. @latkin could you please paste in the errors you're getting?

I don't know what is going on with SourceLink and CRLF/LF. One repo copy on my machine has CRLF and the other has LF. SourceLink only agrees to build the nuget with one of them. I'll file a SourceLink bug.

[dsyme]

Add the sourcelink issue here: ctaggart/SourceLink#119. Until then feel free to disable the SourceLink step if it fails while preparing a release.

[latkin]

ok, I'll clone/build/test clean later on and open an issue with failures.

[rneatherway]

If I use git clone https://github.com/fsharp/FSharp.Compiler.Service -c core.autocrlf=input then sourcelink is OK on my VS2013 machine. But on that machine some tests fail. On my VS2015 VM I can't work out what Windows Debugging Tools package to install from the MS website. When I release I disable one or both of those steps, but it isn't ideal.

[rneatherway]

I have a tiny PR at #528 that gives me a clean run-through of both the tests and SourceLink. This VM has VS2015 and the Windows 10 debugging tools installed.

[ctaggart]

Guys, if you publish the nupkg files built by AppVeyor, you can just run SourceLink target there by adjusting the build.fsx. Change the line to =?> ("SourceLink", isAppVeyorBuild).

[rneatherway]

Guys, if you publish the nupkg files built by AppVeyor

That sounds great, is it easy to promote them?

[ctaggart]

Very easy. Download them from the AppVeyor project NuGet feed and upload them to the NuGet Gallery with nuget.exe or paket.exe or add a new deployment if you are an admin for the project.

[rneatherway]

I've released 2.0.0.5 which includes this change. I can now do a full build Release on one machine as long as I set nugetkey=XXX... first.