Skip to content

Reintegrated compiler editor changes into F# 3.1 source tree #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Dec 17, 2013

Conversation

7sharp9
Copy link
Member

@7sharp9 7sharp9 commented Dec 17, 2013

Replayed my changes over fresh repo to get a clean merge.

ghost pushed a commit that referenced this pull request Dec 17, 2013
Reintegrated compiler editor changes into F# 3.1 source tree
@ghost ghost merged commit b829630 into master Dec 17, 2013
@ghost
Copy link

ghost commented Dec 17, 2013

Great work

@tpetricek
Copy link
Member

Nice :-)

@7sharp9
Copy link
Member Author

7sharp9 commented Dec 17, 2013

I got there eventually!

@panesofglass
Copy link

Thanks @7sharp9! @tpetricek, now it's your turn! ;) I need a new "FsiEval" for the ScriptCs support!

@forki
Copy link
Member

forki commented Dec 17, 2013

Haha.

@ghost ghost deleted the fsharp_31 branch January 12, 2014 18:57
fsgit pushed a commit that referenced this pull request Sep 16, 2014
…when accessing in C#

F# record fields are exposed as properties, and therefore need the "P:" prefix in their XML doc markup.  They were incorrectly being given the "F:" prefix. (changeset 1280439)
dsyme pushed a commit to dsyme/FSharp.Compiler.Service that referenced this pull request Mar 23, 2015
…nvBindTypeRef fsharp#9

Fixes fsharp#10, internal error: binding null type in envBindTypeRef

Both issues were caused by the same underlying issue.  RefEmit automagically applies escaping to names that contain a ','  So ``,`` becomes ``\,``.  When we tried to create a ref to a nested type we didn't add the ',' escaping so we couldnot bind to the created type.

The fix is very straightforward, change BasicQualifiedName to correctly escape names with comma's.
dsyme added a commit to dsyme/FSharp.Compiler.Service that referenced this pull request Sep 28, 2016
baronfel pushed a commit to baronfel/FSharp.Compiler.Service that referenced this pull request Jan 16, 2020
…8063)

* # This is a combination of 9 commits.
# This is the 1st commit message:

ref -> mutable in more places in the compiler

# The commit message fsharp#2 will be skipped:

# Update dependencies from https://github.com/dotnet/arcade build 20191229.1
#
# - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19629.1

# The commit message fsharp#3 will be skipped:

# Update dependencies from https://github.com/dotnet/arcade build 20191230.1
#
# - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19630.1

# The commit message fsharp#4 will be skipped:

# Update dependencies from https://github.com/dotnet/arcade build 20191231.1
#
# - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19631.1

# The commit message fsharp#5 will be skipped:

# Update dependencies from https://github.com/dotnet/arcade build 20200101.1
#
# - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20051.1

# The commit message fsharp#6 will be skipped:

# Update dependencies from https://github.com/dotnet/arcade build 20191216.5 (#8079)
#
# - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19616.5

# The commit message fsharp#7 will be skipped:

# dispose fsi at the end of a scripting session (#8084)
#

# The commit message fsharp#8 will be skipped:

# Added static link tests and extended CompilerAssert (#8101)
#
# * Changed CompilerAssert to static class. Added Compile/Execute methods that take a Compilation description. Added static link tests
# 
# * Hiding compilation description internals
# 
# * Added another test to check for sanity
# 
# * Making a few optional parameters
# 
# * Hiding internals of CompilationReference

# The commit message fsharp#9 will be skipped:

# Parameterize product version (#8031)
#
# * Parameterize Product details
# 
# * fcs
# 
# * Repack pkgdef

* no ilread
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants