Avoid race in channel creation, closes #28 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
===========================================
+ Coverage 43.03% 72.04% +29.01%
===========================================
Files 2 2
Lines 165 161 -4
===========================================
+ Hits 71 116 +45
+ Misses 84 34 -50
- Partials 10 11 +1
Continue to review full report at Codecov.
|
|
I've signed the CLA. Looks like Travis CI is broken. @samjacobson @nathany are you folks still around? |
|
I'm around, but I don't know anything about Travis CI, sorry.
…On Wed, Nov 1, 2017 at 11:20 AM, Lachlan Donald ***@***.***> wrote:
I've signed the CLA. Looks like Travis CI is broken. @samjacobson
<https://github.com/samjacobson> @nathany <https://github.com/nathany>
are you folks still around?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#29 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABMJvcVPh_KntwETFYp4idZ2m0bAJ93jks5sx50ygaJpZM4PpZ75>
.
|
This was referenced Dec 4, 2017
|
hero! this does indeed fix the race I am seeing |
Closed
drewwells
approved these changes
Feb 23, 2018
|
tested this in #35 looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #28 for more detail, this simply avoids a race condition when the events channel is created.