Fix build under Go 1.9.2 and other minor fixes #2
Conversation
Passing a device ID of zero (Host device) to FSEventsCopyUUIDForDevice causes the following assertion failure error to be printed to the logs: (FSEvents.framework) FSEventsCopyUUIDForDevice(): failed assertion 'dev > 0'
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
===========================================
+ Coverage 42.85% 72.22% +29.36%
===========================================
Files 2 2
Lines 161 162 +1
===========================================
+ Hits 69 117 +48
+ Misses 83 34 -49
- Partials 9 11 +2
Continue to review full report at Codecov.
|
example/main.go
Outdated
| @@ -1,4 +1,4 @@ | |||
| // +build darwin | |||
| // +build ignore | |||
There was a problem hiding this comment.
Adding
go_import_path: github.com/fsnotify/fsevents
to the travis.yml should fix this issue b/c then the source code here will be used.
There was a problem hiding this comment.
Then when updating our project that fsevents we can use
govendor fetch github.com/fsnotify/fsevents/^::github.com/elastic/fsevents
to pull down updates from our fork without doing a rename in all imports. I suggest doing it this way with optimism that we will get these changes merged upstream.
This takes the fix elastic/fsevents#2 and overwrites it directly in our vendor directory. This is a temporary fix until the vendoring is updated to our dependency but should bring our builds and packaging back to green.
|
Re-opening. It looks like this was automatically closed when we merged the commit from @ruflin. |
|
Can you squash down those last four related commits? Then I'll use the "rebase and merge" button. |
This pull request incorporates 3 fixes to fsevents:
Fix uint64 overflow during build by remove unnecessary (1 << 64) to kFSEventStreamEventIdSinceNow flag.
Avoid assertion failed error message when requesting a Host Stream (device id = 0).
Fix race condition in channel creation (cherry-picked from Avoid race in channel creation, closes #28 fsnotify/fsevents#29)
Also updates .travis.yml to use Go 1.9.2
Fixes elastic/beats#5783