multipart uploads: Hack to support gsutil cp #1182
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gsutil
sends an invalid multipart boundary param, which golang'smime.ParseMediaType
correctly rejects.However, the real GCS evidently does not reject this, so in order to make
gsutil
work we need to support it.In particular,
gsutil
sends a boundary param that is quoted using single-quotes when it should be using double-quotes.In cases where the param is definitely invalid (so we're guarenteed not to break any valid values), we replace all single-quotes with double-quotes to produce the intended meaning.
Upstream bug: GoogleCloudPlatform/gsutil#1466
Fixes #217
The above issue found this bug and worked around it, but found another problem and never submitted the fix.
It seems that in the intervening time, the other problem was fixed independently, and I can successfully
gsutil cp
using this code.