Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multipart uploads: Hack to support gsutil cp #1182

Merged
merged 2 commits into from
May 27, 2023
Merged

multipart uploads: Hack to support gsutil cp #1182

merged 2 commits into from
May 27, 2023

Commits on May 26, 2023

  1. multipart uploads: Hack to support gsutil cp 

    `gsutil` sends an invalid multipart boundary param, which golang's `mime.ParseMediaType` correctly rejects.
However, the real GCS evidently does not reject this, so in order to make `gsutil` work we need to support it.

In particular, `gsutil` sends a boundary param that is quoted using single-quotes when it should be using double-quotes.
In cases where the param is definitely invalid (so we're guarenteed not to break any valid values), we replace all single-quotes with double-quotes to produce the intended meaning.

Upstream bug: GoogleCloudPlatform/gsutil#1466
    @ekimekim
    ekimekim committed May 26, 2023
    Configuration menu
    Copy the full SHA
    9134d76 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2023

  1. Use ` to avoid having to escape

    @fsouza
    fsouza authored May 27, 2023
    Configuration menu
    Copy the full SHA
    7404445 View commit details
    Browse the repository at this point in the history