Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScriptCompiler doesn't work with TypeScript 1.5 compiler. #1284

Closed
MarcinJuraszek opened this issue Jun 29, 2016 · 2 comments
Closed

TypeScriptCompiler doesn't work with TypeScript 1.5 compiler. #1284

MarcinJuraszek opened this issue Jun 29, 2016 · 2 comments

Comments

@MarcinJuraszek
Copy link

Description

I'm trying to use TypeScriptCompiler but it's failing, because it's looking for TypeScript 1.0, which is an old version. I have TypeScript 1.5 installed on my machine, and I'd expect FAKE to be smart enough to pick it up and use to compile my .ts files.

I can see

let private TypeScriptCompilerPath = 
    @"[ProgramFilesX86]\Microsoft SDKs\TypeScript\1.0\;[ProgramFiles]\Microsoft SDKs\TypeScript\1.0\;[ProgramFilesX86]\Microsoft SDKs\TypeScript\0.9\;[ProgramFiles]\Microsoft SDKs\TypeScript\0.9\"

in https://github.com/fsharp/FAKE/blob/b7630d6e9bdb7caf7640ac38ca4166d9d7717d59/src/app/FakeLib/TypeScript.fs#L43. I think it should be able to use my TypeScript binaries from C:\Program Files (x86)\Microsoft SDKs\TypeScript\1.5 (and probably in a way that will make it work with any new version of TypeScript, and not just 1.5).

@forki
Copy link
Member

forki commented Jun 29, 2016

Please send a pull request
On Jun 29, 2016 4:08 AM, "Marcin Juraszek" notifications@github.com wrote:

Description

I'm trying to use TypeScriptCompiler but it's failing, because it's
looking for TypeScript 1.0, which is an old version. I have TypeScript 1.5
installed on my machine, and I'd expect FAKE to be smart enough to pick it
up and use to compile my .ts files.

I can see

let private TypeScriptCompilerPath =
@"[ProgramFilesX86]\Microsoft SDKs\TypeScript\1.0;[ProgramFiles]\Microsoft SDKs\TypeScript\1.0;[ProgramFilesX86]\Microsoft SDKs\TypeScript\0.9;[ProgramFiles]\Microsoft SDKs\TypeScript\0.9"

in
https://github.com/fsharp/FAKE/blob/b7630d6e9bdb7caf7640ac38ca4166d9d7717d59/src/app/FakeLib/TypeScript.fs#L43.
I think it should be able to use my TypeScript binaries from C:\Program
Files (x86)\Microsoft SDKs\TypeScript\1.5
(and probably in a way that
will make it work with any new version of TypeScript, and not just 1.5).


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1284, or mute the thread
https://github.com/notifications/unsubscribe/AADgNL3hhcy2IOHQeLDn1O40gwLKhLoVks5qQdOLgaJpZM4JAtMC
.

@alexfoxgill
Copy link

You can specify the path using the ToolPath parameter. For example

!! ("**/*.ts")
|> TypeScriptCompiler (fun p -> { p with ToolPath = @"C:\Program Files (x86)\Microsoft SDKs\TypeScript\1.8\tsc.exe" })

However, perhaps it would be nice for FAKE to look for the most recent version of TypeScript in the standard directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants