Use latest TypeScript compiler version automatically #1320
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small feature addresses #1284 by allowing a version wildcard in
tryFindFile
. When given a path containing the wildcard[v]
, the algorithm will search the the parent directory for subdirectories matching a regular expression which identifies digits separated by dots (e.g.1.8
)The
TypeScriptCompilerPath
has been updated to use the feature:I have not written any tests for this method, as it is difficult to mock the filesystem, which the
tryFindFile
method relies on. Perhaps a configurable proxy module could be created to provideDirectory.GetDirectories
,Directory.Exists
andFile.Exists
and provide override methods in test code... But I think this is overkill.