Reinstate Disposal #149
Merged
Reinstate Disposal #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests pass on the desktop. |
abelbraaksma
force-pushed
the
reinstate-disposal
branch
from
57a185f to
d9ce72d
Compare
|
Thanks for testing this and our discussions on Slack ❤️!!! Sorry to leave this hanging so long, I kinda/sorta wanted to get other stuff baselined as well, but this is too important and should've been fixed already. Merging now, publishing tomorrow. |
abelbraaksma
force-pushed
the
reinstate-disposal
branch
from
d9ce72d to
67c3800
Compare
|
Strange, I thought I can edit this with GH CodeSpaces. While it allows me to edit, I get a 403 when trying to commit to this PR. When I do it locally though, just check out this PR and commit & push, it "just works" ™️ (needed to update the release notes before merging) |
bartelink
commented
Jun 2, 2023
Co-authored-by: Ruben Bartelink <ruben@bartelink.com>
abelbraaksma
added
bug fix
topic: taskseq-ce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #157
https://github.com/jet/equinox and propulsion both depend on the following
taskSeqfeaturesuse!in task expressionstry/finallyThis PR reinstates this functionality, which accidentally got disabled in 27486f3
(edited in place to refer to the issue)