Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mkdir broken for adlfs #166

Closed
dtrifiro opened this issue Dec 15, 2023 · 0 comments · Fixed by #177
Closed

mkdir broken for adlfs #166

dtrifiro opened this issue Dec 15, 2023 · 0 comments · Fixed by #177
Assignees
@ap--
Labels
bug 🐛 Something isn't working
Milestone
v0.2

Comments

@dtrifiro
Copy link
Contributor

In #83, mkdir(parents=True) switched from using self._accessor.mkdir to self._accessor.makedirs.

For some implementations (such as adlfs and gcsfs, possibly more), makedirs is not implemented, causing calling upath.mkdir to be a no-op, whereas it previously worked to create containers/buckets.

See dtrifiro@fac2bcf on https://github.com/dtrifiro/universal_pathlib/tree/broken-mkdir-examples
dtrifiro added a commit to iterative/pytest-servers that referenced this issue Dec 15, 2023
@dtrifiro
azure/gcs: fix container/bucket creation
dcca75d 
Calling mkdir with parents=True now calls makedirs, which is
not implemented for gcsfs and adlfs, requiring us to use these
workarounds to properly create buckets/containers.

See fsspec/universal_pathlib#166
dtrifiro added a commit to iterative/pytest-servers that referenced this issue Dec 15, 2023
@dtrifiro
azure/gcs: fix container/bucket creation
b6ffa34 
Calling mkdir with parents=True now calls makedirs, which is
not implemented for gcsfs and adlfs, requiring us to use these
workarounds to properly create buckets/containers.

See fsspec/universal_pathlib#166
dtrifiro added a commit to iterative/pytest-servers that referenced this issue Dec 15, 2023
@dtrifiro
azure/gcs: fix container/bucket creation
a3c0836 
Calling mkdir with parents=True now calls makedirs, which is
not implemented for gcsfs and adlfs, requiring us to use these
workarounds to properly create buckets/containers.

See fsspec/universal_pathlib#166
dtrifiro added a commit to iterative/pytest-servers that referenced this issue Dec 15, 2023
@dtrifiro
azure/gcs: fix container/bucket creation
26dd4dd 
Calling mkdir with parents=True now calls makedirs, which is
not implemented for gcsfs and adlfs, requiring us to use these
workarounds to properly create buckets/containers.

See fsspec/universal_pathlib#166
@ap-- ap-- self-assigned this Jan 17, 2024
@ap-- ap-- added the bug 🐛 Something isn't working label Jan 17, 2024
@ap-- ap-- added this to the v0.2 milestone Feb 8, 2024
@ap-- ap-- mentioned this issue Feb 8, 2024
Merged
@ap-- ap-- closed this as completed in #177 Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ap-- ap--

Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
v0.2
Development

Successfully merging a pull request may close this issue.

Fix broken mkdir ap--/universal_pathlib
2 participants
@ap-- @dtrifiro