Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect exist_ok in mkdir when creating parent directories #83

Merged
merged 3 commits into from
Mar 11, 2023
Merged

Respect exist_ok in mkdir when creating parent directories #83

merged 3 commits into from
Mar 11, 2023

Conversation

rahuliyer95
Copy link
Contributor

Fix for #82

@rahuliyer95
Copy link
Contributor Author

Requesting review: @normanrz

@rahuliyer95
Copy link
Contributor Author

@normanrz if you can please take another pass at it, now that the tests are passing, Thanks!

@normanrz
Copy link
Collaborator

Thanks for the PR. The code looks good to me. Would you mind adding a test for makedirs as well?

normanrz
normanrz approved these changes Mar 11, 2023
View reviewed changes
Copy link
Collaborator

@normanrz normanrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for putting together this PR!

@normanrz normanrz merged commit 3ef5e6f into fsspec:main Mar 11, 2023
@normanrz
Copy link
Collaborator

I just published it in v0.0.22

@rahuliyer95 rahuliyer95 deleted the issue-82/fix-mkdir branch May 11, 2023 16:17
@dtrifiro dtrifiro mentioned this pull request Dec 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normanrz normanrz normanrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahuliyer95 @normanrz