-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support setting decodeDatesAsIso globally #159
Conversation
Oh, we missed adding this in the constructor? Our bad – thanks for the patch! Please move the option to the call function, and we can merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
decodeDatesAsIso
is defaulted to false in call, so that won't work either. Probably best to default all the different decodeDatesAsIso
( in decode()
and call()
) to this.decodeDatesAsISO
, instead of making other changes inside call()
.
Also, would be great if you could add tests for this as well, but not strictly necessary.
I tried doing this now. Let me know if I understood what you meant correctly. If not, I think I need some assistance perhaps? |
Co-authored-by: Lars Johansson <gismya@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added tests, fixed a type error, and prettier formatting.
Thank you @ffMathy!
Thanks for the assist! ❤️ And sorry for maybe not being too thorough around testing. Things are busy these days, so I must admit I've been trying to limit my investment in this. |
No worries at all. Appreciate any contributions. |
Resolves #187