Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support setting decodeDatesAsIso globally #159

Merged
merged 9 commits into from
Oct 10, 2023
Merged

fix: support setting decodeDatesAsIso globally #159

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fd09316
Update session.ts
ffMathy Oct 5, 2023
87eddb0
fix: review changes
ffMathy Oct 5, 2023
61a62ea
Update session.ts
ffMathy Oct 7, 2023
349318c
Update session.ts
ffMathy Oct 9, 2023
d3cb6dd
Update session.ts
ffMathy Oct 9, 2023
882c39b
Update source/session.ts
ffMathy Oct 10, 2023
017d9e5
Add session decodeDatesAsIso tests
gismya Oct 10, 2023
2958d15
Add decodeDatesAsIso to SessionOptions interface
gismya Oct 10, 2023
15ee356
Prettier formatting
gismya Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions source/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ export class Session {
schemas?: Schema[];
serverInformation?: QueryServerInformationResponse;
serverVersion?: string;
private decodeDatesAsIso: boolean;
private schemasPromise?: Promise<Schema[]>;
private serverInformationPromise?: Promise<ServerInformation>;
private serverInformationValues?: string[];
Expand All @@ -80,7 +81,7 @@ export class Session {
* @param {string} [options.apiEndpoint=/api] - API endpoint.
* @param {object} [options.headers] - Additional headers to send with the request
* @param {object} [options.strictApi] - Turn on strict API mode
* @param {object} options.decodeDatesAsIso - Decode dates as ISO strings instead of moment objects
* @param {object} [options.decodeDatesAsIso] - Decode dates as ISO strings instead of moment objects
*
* @constructs Session
*/
Expand All @@ -96,6 +97,7 @@ export class Session {
apiEndpoint = "/api",
additionalHeaders = {},
strictApi = false,
decodeDatesAsIso = false
}: SessionOptions = {},
) {
if (!serverUrl || !apiUser || !apiKey) {
Expand Down Expand Up @@ -190,6 +192,8 @@ export class Session {
{ action: "query_schemas" },
];

this.decodeDatesAsIso = decodeDatesAsIso;

/**
* true if session is initialized
* @memberof Session
Expand Down Expand Up @@ -624,7 +628,7 @@ export class Session {
throw this.getErrorFromResponse(response);
}
try {
return this.decode(response, {}, decodeDatesAsIso);
return this.decode(response, {}, this.decodeDatesAsIso || decodeDatesAsIso);
ffMathy marked this conversation as resolved.
Show resolved Hide resolved
} catch (reason) {
logger.warn("Server reported error in unexpected format. ", reason);
throw this.getErrorFromResponse({
Expand Down