Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

star-citizen 1.6.10 -> 2.0.5 #199

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

LovingMelody
Copy link
Contributor

@LovingMelody LovingMelody commented Sep 2, 2024

  • Bump star-citizen to 2.0.3
  • Bump winetricks to git versions
  • Add options enableGameScope gameScopeArgs

@LovingMelody LovingMelody marked this pull request as draft September 2, 2024 02:17
@LovingMelody
Copy link
Contributor Author

Placing this as draft, submitting a PR to nixpkgs for proton-ge-9-12 which would change things for this package as well.

@LovingMelody
Copy link
Contributor Author

Considering bumping this to 2.0 launcher, proton-ge-12 has the powershell fixes. latest git for winetricks has it as well.

@fufexan do you have any opinions on adding winetricks-git to this repo?

@fufexan
Copy link
Owner

fufexan commented Sep 2, 2024

No objections, feel free.

@LovingMelody LovingMelody force-pushed the update-star-citizen branch 2 times, most recently from 5f1a1aa to 5f6792f Compare September 8, 2024 23:56
@LovingMelody LovingMelody changed the title star-citizen 1.6.10 -> 1.6.11 star-citizen 1.6.10 -> 2.0.3 Sep 8, 2024
@LovingMelody
Copy link
Contributor Author

LovingMelody commented Sep 8, 2024

proton-ge-bin update is now in nixpkgs-unstable
this PR is not ready to be merged until #201 is in (And current testing goes well)

@LovingMelody
Copy link
Contributor Author

Confirmed game is running as expected.

@LovingMelody LovingMelody marked this pull request as ready for review September 10, 2024 18:17
Copy link
Owner

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for the delay!

@fufexan
Copy link
Owner

fufexan commented Sep 26, 2024

Oops, looks like npins is conflicting.

* Bump star-citizen to 2.0.5
* change winetricks version to winetricks-git
* Add options `enableGameScope` `gameScopeArgs`
@LovingMelody LovingMelody changed the title star-citizen 1.6.10 -> 2.0.3 star-citizen 1.6.10 -> 2.0.5 Sep 27, 2024
@LovingMelody
Copy link
Contributor Author

Launcher has been bumped to 2.0.5 and wine has been updated from wine-ge to latest wine stable.

Copy link
Owner

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fufexan fufexan merged commit 615ff6f into fufexan:master Sep 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants