Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init: winetricks-git rev72b934e1e10c041ec6986f5f2fb4f143d8f6b941 #201

Merged
merged 1 commit into from
Sep 10, 2024
Merged

init: winetricks-git rev72b934e1e10c041ec6986f5f2fb4f143d8f6b941 #201

merged 1 commit into from
Sep 10, 2024

Conversation

LovingMelody
Copy link
Contributor

Initialize winetricks-git at the latest git rev

@LovingMelody LovingMelody mentioned this pull request Sep 8, 2024
Merged
fufexan
fufexan reviewed Sep 10, 2024
View reviewed changes
Copy link
Owner

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be easier to simply override the winetricks derivation in nixpkgs and change its src and version?

@LovingMelody
Copy link
Contributor Author

LovingMelody commented Sep 10, 2024 •
edited
Loading

Maybe though the definition doesn't really change as far as I can tell from the commit history. Winetricks only updates once a year so if anything git would be more likely to get a new definition change.

@fufexan
Copy link
Owner

fufexan commented Sep 10, 2024

Alright, it doesn't matter much anyway.

@fufexan fufexan merged commit 5e1b352 into fufexan:master Sep 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fufexan fufexan fufexan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LovingMelody @fufexan