Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make error message for workflow downloads more precise #296

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Make error message for workflow downloads more precise #296

merged 1 commit into from
Nov 30, 2022

Conversation

LeStegii
Copy link
Contributor

@LeStegii LeStegii commented Nov 29, 2022

Please not that this PR has not been tested very well due to the complex workspace setup. Please test before merging!

If you disable local storage in the privacy settings, create a workflow using fulibWorkflows and try to download any type of output, it prints out an error into the little toast in the upper right corner. The error says: "Download Files - Editor Content does not exist". It doesn't matter what types of outputs are selected.

While this is not an error/a bug, the message displayed suggests that something went wrong and the content doesn't exist. Instead something like "Could not download files - Please allow the use of local data storage in your Privacy Preferences." should be displayed.

Improvements

Closes #295

@Clashsoft Clashsoft merged commit 44ece62 into fujaba:master Nov 30, 2022
@Clashsoft Clashsoft added this to the v1.13.1 milestone Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download button for workflows shows incorrect error message
2 participants