Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to resolve AS info for IP addresses without PTR #479

Closed
hexchain opened this issue Mar 31, 2023 · 5 comments · Fixed by #480
Closed

Try to resolve AS info for IP addresses without PTR #479

hexchain opened this issue Mar 31, 2023 · 5 comments · Fixed by #480
Labels
dns enhancement New feature or request
Milestone

Comments

@hexchain
Copy link

Currently, if an IP address of a hop does not have a reverse record, then its AS info also won't be looked up. This seems like a pretty strange limitation.

Would it be sensible to enable AS info lookup for all IP addresses, regardless of whether PTR exists?

@fujiapple852 fujiapple852 added the enhancement New feature or request label Apr 1, 2023
@fujiapple852 fujiapple852 self-assigned this Apr 1, 2023
@fujiapple852 fujiapple852 added this to the 0.8.0 milestone Apr 1, 2023
@fujiapple852
Copy link
Owner

Thanks @hexchain, I agree that it makes sense to try and lookup AS info for all IP addresses.

I'll include this in the next release, if you want to try it out now you can build from #480

@fujiapple852
Copy link
Owner

fujiapple852 commented Apr 1, 2023

Aside: Trippy looks up additional data about each AS, specifically:

pub struct AsInfo {
    pub asn: String,
    pub prefix: String,
    pub cc: String,
    pub registry: String,
    pub allocated: String,
    pub name: String,
}

Currently only asn (i.e. AS15169) is displayed, but we could display any/all of the other fields. Most useful is name (i.e. "GOOGLE, US") but this is often quite long so perhaps not well suited to be displayed in the hops table.

@fujiapple852
Copy link
Owner

fujiapple852 commented Apr 3, 2023

@hexchain also added a new --tui-as-mode config argument to specify what to display, see #483

@fujiapple852
Copy link
Owner

@hexchain 0.8.0 which includes this change has been released: https://github.com/fujiapple852/trippy/releases/tag/0.8.0

@hexchain
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dns enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants