Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GeoIp Map View #505

Closed
fujiapple852 opened this issue Apr 18, 2023 · 3 comments · Fixed by #511
Closed

GeoIp Map View #505

fujiapple852 opened this issue Apr 18, 2023 · 3 comments · Fixed by #511
Labels
enhancement New feature or request geoip tui
Milestone
0.8.0

Comments

@fujiapple852
Copy link
Owner

No description provided.

This was referenced Apr 18, 2023
Closed
Merged
@fujiapple852
Copy link
Owner Author

@schlunsen first attempt to add the Map and GeoIp labels in #511. It looks sensible (the countries seem to show up where they should!). It does seem that many IPs do not have GeoIp data from the mmdb and some only have very vague data such as only the country.

@fujiapple852 fujiapple852 added enhancement New feature or request geoip labels Apr 19, 2023
@fujiapple852
Copy link
Owner Author

WIP updated to show the hops (shown as a 📍) and an accuracy radius (yellow circle) for each. The location of the currently selected hop is also shown (green square):

Screenshot 2023-04-25 at 9 53 09 PM

If the selected hop has multiple associated IPs (as can happen with ECMP routing) then multiple map locations will be highlighted with the green square. However the dialog box at the bottom shows only a single location per hop, not sure how best to fix that.

@fujiapple852 fujiapple852 self-assigned this Apr 25, 2023
@fujiapple852 fujiapple852 added this to the 0.8.0 milestone Apr 25, 2023
fujiapple852 added a commit that referenced this issue Apr 26, 2023
@fujiapple852
feat: add geoip map view (#505)
0bdf9b9
fujiapple852 added a commit that referenced this issue Apr 26, 2023
@fujiapple852
doc: update CHANGELOG.md to add #505
a475251
fujiapple852 added a commit that referenced this issue Apr 26, 2023
@fujiapple852
doc: update CHANGELOG.md to add #505
585876c
fujiapple852 added a commit that referenced this issue Apr 26, 2023
@fujiapple852
feat: add geoip map view (#505)
48a9495
fujiapple852 added a commit that referenced this issue Apr 26, 2023
@fujiapple852
doc: update CHANGELOG.md to add #505
2fe7e74
@fujiapple852
Copy link
Owner Author

This has been polished and merged. it will be available in 0.8.0

@fujiapple852 fujiapple852 removed their assignment Apr 26, 2023
@fujiapple852 fujiapple852 mentioned this issue Apr 29, 2023
Merged
@p-linnane p-linnane mentioned this issue May 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request geoip tui
Projects
None yet
Milestone
0.8.0
Development

Successfully merging a pull request may close this issue.

Add GeoIp map view (#505) fujiapple852/trippy
1 participant
@fujiapple852