NAT detection for IPv4/UDP/Dublin #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fujiapple852
force-pushed
the
feat-nat
branch
3 times, most recently
from
53c32f5
to
0102d94
Compare
|
Cannot currently detect NAT at the very first hop. |
|
Updated impl which now compares the expected UDP checksum vs the actual UDP checksum for the original datagram nested in the payload of the ICMP packet. This should allow detecting NAT for the 1st hop (when there is no previous hop checksum to compare with). Adds to the complexity a fair bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1104
Closes #1219