Misc changes

src/config.rs

@@ -41,10 +41,10 @@ const MIN_GRACE_DURATION_MS: Duration = Duration::from_millis(10);
 const MAX_GRACE_DURATION_MS: Duration = Duration::from_millis(1000);
 
 /// The minimum packet size we allow.
-pub const MIN_PACKET_SIZE: u16 = 28;
+const MIN_PACKET_SIZE: u16 = 28;
 
 /// The maximum packet size we allow.
-pub const MAX_PACKET_SIZE: u16 = 1024;
+const MAX_PACKET_SIZE: u16 = 1024;
 
 /// The tool mode.
 #[derive(Debug, Copy, Clone, ValueEnum)]
@@ -315,7 +315,7 @@ pub struct Args {
     pub print_tui_binding_commands: bool,
 
     /// The number of report cycles to run
-    #[clap(short = 'c', long, default_value_t = 10, display_order = 36)]
+    #[clap(short = 'C', long, default_value_t = 10, display_order = 36)]
     pub report_cycles: usize,
 }
 

src/main.rs

@@ -8,7 +8,8 @@
     clippy::cast_possible_truncation,
     clippy::redundant_pub_crate,
     clippy::struct_excessive_bools,
-    clippy::cognitive_complexity
+    clippy::cognitive_complexity,
+    clippy::option_option
 )]
 #![forbid(unsafe_code)]
 use crate::backend::Trace;

src/tracing/net/ipv4.rs

@@ -221,8 +221,7 @@ fn make_echo_request_icmp_packet(
     payload_size: usize,
     payload_pattern: PayloadPattern,
 ) -> TraceResult<EchoRequestPacket<'_>> {
-    let mut payload_buf = [0_u8; MAX_ICMP_PAYLOAD_BUF];
-    payload_buf.iter_mut().for_each(|x| *x = payload_pattern.0);
+    let payload_buf = [payload_pattern.0; MAX_ICMP_PAYLOAD_BUF];
     let packet_size = IcmpPacket::minimum_packet_size() + payload_size;
     let mut icmp = EchoRequestPacket::new(&mut icmp_buf[..packet_size]).req()?;
     icmp.set_icmp_type(IcmpType::EchoRequest);

src/tracing/net/ipv6.rs

@@ -99,7 +99,6 @@ pub fn dispatch_tcp_probe(
     probe: Probe,
     src_addr: Ipv6Addr,
     dest_addr: Ipv6Addr,
-    // port_direction: PortDirection,
 ) -> TraceResult<Socket> {
     fn process_result(addr: SocketAddr, res: std::io::Result<()>) -> TraceResult<()> {
         match res {
@@ -224,8 +223,7 @@ fn make_echo_request_icmp_packet(
     payload_size: usize,
     payload_pattern: PayloadPattern,
 ) -> TraceResult<EchoRequestPacket<'_>> {
-    let mut payload_buf = [0_u8; MAX_ICMP_PAYLOAD_BUF];
-    payload_buf.iter_mut().for_each(|x| *x = payload_pattern.0);
+    let payload_buf = [payload_pattern.0; MAX_ICMP_PAYLOAD_BUF];
     let packet_size = IcmpPacket::minimum_packet_size() + payload_size;
     let mut icmp = EchoRequestPacket::new(&mut icmp_buf[..packet_size]).req()?;
     icmp.set_icmp_type(IcmpType::EchoRequest);