Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for --unprivileged mode (MacOS only) #638

Merged
merged 10 commits into from
Nov 1, 2023
Merged

Add Support for --unprivileged mode (MacOS only) #638

merged 10 commits into from
Nov 1, 2023

Conversation

fujiapple852
Copy link
Owner

Closes #101

@fujiapple852 fujiapple852 marked this pull request as draft August 12, 2023 14:08
@fujiapple852 fujiapple852 force-pushed the feat-unprivileged-icmp branch 3 times, most recently from ddca5aa to 7b52b87 Compare August 26, 2023 12:57
@fujiapple852 fujiapple852 force-pushed the feat-unprivileged-icmp branch 7 times, most recently from 59e268c to 8a89aef Compare October 22, 2023 09:51
@fujiapple852 fujiapple852 changed the title WIP: Feat unprivileged icmp Add Support for unprivileged mode Oct 22, 2023
@fujiapple852 fujiapple852 mentioned this pull request Oct 23, 2023
Closed
@fujiapple852 fujiapple852 force-pushed the feat-unprivileged-icmp branch 3 times, most recently from f077c49 to 634cd25 Compare October 29, 2023 09:01
@fujiapple852 fujiapple852 changed the title Add Support for unprivileged mode Add Support for --unprivileged mode (MacOS only) Oct 29, 2023
@fujiapple852 fujiapple852 marked this pull request as ready for review October 29, 2023 09:10
@fujiapple852
Copy link
Owner Author

fujiapple852 commented Oct 29, 2023 •
edited
Loading

Unprivileged mode for Ipv6 on macOS has not been tested as I have no way to test it. However as this mode is opt-in we are safe to merge this. Edit: now tested on Ipv6 on macOS

@fujiapple852 fujiapple852 force-pushed the feat-unprivileged-icmp branch 5 times, most recently from b9fd429 to 941a25d Compare October 31, 2023 10:36
@fujiapple852 fujiapple852 merged commit bebb30c into master Nov 1, 2023
10 checks passed
@fujiapple852 fujiapple852 deleted the feat-unprivileged-icmp branch November 1, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for --unprivileged mode (MacOS only)
1 participant
@fujiapple852