New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing undefined's from filter arguments #137

Merged

auser merged 1 commit into fullstackreact:master from pedro-ribeiro:fixing_trailing_comma

Nov 16, 2016

Contributor

pedro-ribeiro commented Nov 16, 2016

Removes trailing comma. java String#split has a different behaviour from componentsseparatedbystring, which leads to a bug.
Problem resides in equalTo passing undefined to setFilter when no key is present.
Not tested besides equalTo filter in android! Can break other filters. Requires further testing.


          removing trailing comma

487ed30

pedro-ribeiro mentioned this pull request

[v3] Queries with equalTo() return null #121

Open

auser merged commit a0a78e5 into fullstackreact:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet