This repository has been archived by the owner on Mar 29, 2024. It is now read-only.
WIP: backport SOLR-15555, async caching #170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a new cache mode for CaffeineCache where we can optionally use an async cache instead of the synchronous implementation. This is useful for cases (esp FilterQuery) where many identical requests come in near the same time and they would otherwise race to fill the same cache slot. CaffeineCache computeIfAbsent now accepts an IOFunction instead of the non-throwing java.util.Function interface. This required an update to CaffeineCache 2.9, which updates putIfAbsent with an optimistic get. Also incidentally fixes a rare bug where cache ramBytesUsed would be incorrectly reported under heavy cache contention/eviction loads. Makes Async Caches the default. (cherry picked from commit ac5df22)
(cherry picked from commit d10fd79)
(cherry picked from commit 437ba13)
magibney
changed the title
…lgibney/backport_SOLR-15555
…lgibney/backport_SOLR-15555
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See SOLR-15555.
This is not immediately/directly necessary, but it makes sense for any work on upstream caching to incorporate these changes first (to minimize potential for merge conflicts, etc.).
There is no rush to merge this -- it's mainly here to provide a stable base for other caching work, but it could benefit some use cases (and issues introduced locally by this, if any, would be encountered anyway soon enough with the next local solr version upgrade).