Merge pull request #403 from funidata/DS-321-dialog-double-scrollbar-fix

[Dialog, TextArea]: Fix double scrollbar and validity observable subscibe
funidata · Jun 28, 2024 · a0e28b3 · a0e28b3
2 parents d88b328 + 0128684
commit a0e28b3
Show file tree

Hide file tree

Showing 11 changed files with 2 additions and 0 deletions.
diff --git a/ngx-fudis/projects/ngx-fudis/src/lib/components/dialog/ngMaterial-theme.scss b/ngx-fudis/projects/ngx-fudis/src/lib/components/dialog/ngMaterial-theme.scss
@@ -35,6 +35,7 @@
     & .mat-mdc-dialog-surface {
       border-radius: 0;
       box-shadow: none;
+      overflow-y: visible; /** This was set to auto by ngMaterial, it caused double scrollbar in Sisu environment. This is a try-out fix */
 
       & .mat-mdc-dialog-title {
         margin: spacing.$spacing-xxs 0 spacing.$spacing-sm 0;

diff --git a/ngx-fudis/projects/ngx-fudis/src/lib/components/form/text-area/text-area.component.ts b/ngx-fudis/projects/ngx-fudis/src/lib/components/form/text-area/text-area.component.ts
@@ -69,6 +69,7 @@ export class TextAreaComponent
 
   ngOnInit(): void {
     this._setInputId('text-area');
+    this._updateValueAndValidityTrigger.next();
 
     /**
      * TODO: write test

diff --git a/...sion/dialog.spec.ts-snapshots/form-1-init-Mobile-Safari-Big-Landscape-linux.png b/...sion/dialog.spec.ts-snapshots/form-1-init-Mobile-Safari-Big-Landscape-linux.png
diff --git a/...on/dialog.spec.ts-snapshots/form-2-errors-Mobile-Safari-Big-Landscape-linux.png b/...on/dialog.spec.ts-snapshots/form-2-errors-Mobile-Safari-Big-Landscape-linux.png
diff --git a/...og.spec.ts-snapshots/form-3-before-submit-Mobile-Safari-Big-Landscape-linux.png b/...og.spec.ts-snapshots/form-3-before-submit-Mobile-Safari-Big-Landscape-linux.png
diff --git a/.../visual-regression/dialog.spec.ts-snapshots/grid-1-init-Mobile-Safari-linux.png b/.../visual-regression/dialog.spec.ts-snapshots/grid-1-init-Mobile-Safari-linux.png
diff --git a/test/visual-regression/dialog.spec.ts-snapshots/grid-1-init-webkit-linux.png b/test/visual-regression/dialog.spec.ts-snapshots/grid-1-init-webkit-linux.png
diff --git a/...egression/dialog.spec.ts-snapshots/grid-2-content-focus-Mobile-Safari-linux.png b/...egression/dialog.spec.ts-snapshots/grid-2-content-focus-Mobile-Safari-linux.png
diff --git a/...isual-regression/dialog.spec.ts-snapshots/grid-2-content-focus-webkit-linux.png b/...isual-regression/dialog.spec.ts-snapshots/grid-2-content-focus-webkit-linux.png
diff --git a/...ession/dialog.spec.ts-snapshots/grid-3-content-scrolled-Mobile-Safari-linux.png b/...ession/dialog.spec.ts-snapshots/grid-3-content-scrolled-Mobile-Safari-linux.png
diff --git a/...al-regression/dialog.spec.ts-snapshots/grid-3-content-scrolled-webkit-linux.png b/...al-regression/dialog.spec.ts-snapshots/grid-3-content-scrolled-webkit-linux.png