[Dialog, TextArea]: Fix double scrollbar and validity observable subscibe #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ottom border color slightly. Let us roll with that and update base images.
github-actions
bot
temporarily deployed
to
Documentation for branch DS-321-dialog-double-scrollbar-fix
RiinaKuu
changed the title
github-actions
bot
temporarily deployed
to
Documentation for branch DS-321-dialog-double-scrollbar-fix
MayaMarjut
approved these changes
Jun 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://funidata.atlassian.net/browse/DS-321
Double scrollbar appears in Sisu environment inside Dialogs with Form, this did not reproduce in Storybook.
overflow-yvalue inside.mat-mdc-dialog-surfaceclass. This is initial try to fix the issue but might need more looking into it if the problem still occurs.overflow-yit made tiny color changes to Dialog's top/bottom borders in Safari and webkit browsers (decided to roll with it)Fixed TextArea's
ExpressionChangedAfterItHasBeenCheckedErrorwhich was caused due to lacking observable subscribe.