Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select, Multiselect]: Add filter help text features and update tests #389

Merged
merged 29 commits into from
Jun 20, 2024

Conversation

videoeero
Copy link
Contributor

@videoeero videoeero commented Jun 13, 2024

Jira ticket: https://funidata.atlassian.net/browse/DS-315

New features:

  • Select & Multiselect Option can now now have subLabel property
  • New property autocompleteHelpText for Select & Multiselect displays a help text as first item in their Dropdown
    • By default it will display "Showing X results" but can be overriden by application
    • By setting property as false will disable it

Also added loads of new unit tests and tweaked Playwright tests.

@videoeero videoeero marked this pull request as draft June 13, 2024 15:52
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-315-select-tests-and-minor-new-feats June 13, 2024 20:24 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-315-select-tests-and-minor-new-feats June 17, 2024 17:42 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-315-select-tests-and-minor-new-feats June 17, 2024 18:19 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-315-select-tests-and-minor-new-feats June 17, 2024 18:51 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-315-select-tests-and-minor-new-feats June 17, 2024 20:28 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-315-select-tests-and-minor-new-feats June 17, 2024 20:41 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-315-select-tests-and-minor-new-feats June 18, 2024 07:23 Destroyed
@videoeero videoeero added the improvement Improve or extend something that already exists label Jun 18, 2024
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-315-select-tests-and-minor-new-feats June 18, 2024 11:31 Destroyed
@videoeero videoeero marked this pull request as ready for review June 18, 2024 13:46
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-315-select-tests-and-minor-new-feats June 18, 2024 18:38 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-315-select-tests-and-minor-new-feats June 19, 2024 08:35 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-315-select-tests-and-minor-new-feats June 19, 2024 11:43 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-315-select-tests-and-minor-new-feats June 19, 2024 12:20 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-315-select-tests-and-minor-new-feats June 20, 2024 09:32 Destroyed
@RiinaKuu RiinaKuu merged commit ba98ca0 into main Jun 20, 2024
10 checks passed
@RiinaKuu RiinaKuu deleted the DS-315-select-tests-and-minor-new-feats branch June 20, 2024 10:25
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
improvement Improve or extend something that already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants