Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select, Multiselect]: Add filter help text features and update tests #389

Merged
merged 29 commits into from
Jun 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
bc8cc26
DS-315: add new features
videoeero Jun 13, 2024
cbbcd71
DS-316: adjust dropdown helper texts
videoeero Jun 13, 2024
7c5d2e0
DS-315: show helptext when filtertext
videoeero Jun 13, 2024
8c601ff
DS-315: toggle dropdown from chevron click
videoeero Jun 13, 2024
29dfd6d
DS-315: update vr tests
videoeero Jun 13, 2024
e0a3906
DS-315: update vr tests
videoeero Jun 13, 2024
5bcc868
DS-315: SelectGroup unit tests
videoeero Jun 13, 2024
ab3057c
DS-315: select-icons tests
videoeero Jun 13, 2024
74ca472
DS-315: select dropdown test updates
videoeero Jun 17, 2024
c8c9913
DS-315: chiplist test updates
videoeero Jun 17, 2024
7a6ec25
DS-315: id to body text
videoeero Jun 17, 2024
8bf57b5
DS-315: autocomplete cleaning
videoeero Jun 17, 2024
99e9210
DS-315: autocomplete unit tests
videoeero Jun 17, 2024
9c40bda
DS-315: vr test update
videoeero Jun 17, 2024
bcf0bfe
Merge branch 'main' into DS-315-select-tests-and-minor-new-feats
videoeero Jun 17, 2024
f13d305
DS-315: filter by subLabel
videoeero Jun 17, 2024
f3cab64
DS-315: cleaning
videoeero Jun 17, 2024
746bb95
DS-315: fix test
videoeero Jun 17, 2024
0558788
DS-315: select utils unit tests
videoeero Jun 18, 2024
04c4c4f
DS-315: adjust tests and docs
videoeero Jun 18, 2024
106354e
DS-315: adjust storybook examples
videoeero Jun 18, 2024
0f61546
DS-315: select base tests
videoeero Jun 18, 2024
c25a9b4
DS-315: select-option-base test updates
videoeero Jun 19, 2024
4da2b62
DS-315: select option tests
videoeero Jun 19, 2024
6d7f68a
DS-315: multiselect option test update
videoeero Jun 19, 2024
8560188
DS-315: cleaning
videoeero Jun 19, 2024
4cc914f
DS-315: cleaning
videoeero Jun 19, 2024
f77ff53
DS-315: cleaning
videoeero Jun 19, 2024
cd06eee
DS-315: fix select base tests
videoeero Jun 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ngx-fudis/projects/dev/tsconfig.app.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@
{
"extends": "../../tsconfig.json",
"compilerOptions": {
"outDir": "../../out-tsc/app",
"types": []
"outDir": "../../out-tsc/app"
},
"files": ["src/main.ts", "src/polyfills.ts", "src/app/transloco-loader.ts"],
"include": ["src/**/*.d.ts"]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
<input
#inputRef
type="text"
aria-required="true"
class="fudis-form-input fudis-select-autocomplete"
class="fudis-select-autocomplete fudis-form-input"
role="combobox"
[attr.value]="selectedLabel || null"
[attr.aria-controls]="id + '-dropdown'"
Expand All @@ -11,19 +10,18 @@
(focus)="_inputFocus($event)"
(blur)="_inputBlur($event)"
(click)="_inputClick($event)"
(keyup)="!disabled && !control.disabled && _keyUp($event)"
(keypress)="!disabled && !control.disabled && _keyPress()"
(keydown)="!disabled && !control.disabled && _keyDown($event)"
(keyup)="!disabled && _keyUp($event)"
(keypress)="!disabled && _keyPress()"
(keydown)="!disabled && _keyDown($event)"
[attr.id]="id"
autocomplete="off"
[attr.aria-autocomplete]="'list'"
[attr.aria-expanded]="dropdownOpen"
[attr.aria-disabled]="control.disabled || disabled"
[attr.aria-disabled]="disabled || null"
[attr.placeholder]="placeholder"
[attr.required]="required ? true : null"
[attr.required]="required || null"
[attr.aria-required]="required || null"
[attr.aria-labelledby]="id + '-label'"
[attr.aria-describedby]="id + '_guidance'"
[attr.aria-invalid]="
(control.touched && control.invalid) || (control.touched && invalidState) ? true : null
"
[attr.aria-invalid]="invalidState || null"
/>
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,11 @@

.fudis-select-autocomplete {
@include typography.text-field-input;
@include borders.border("1px", "solid", "gray-dark");
@include borders.border-radius("2px");

box-sizing: border-box;
display: flex;
align-items: baseline;
align-items: center;
justify-content: flex-start;
padding: spacing.$spacing-xxs spacing.$spacing-lg spacing.$spacing-xxs spacing.$spacing-sm;
width: 100%;
Expand All @@ -28,4 +27,14 @@
&:focus-visible {
@include focus.focus-form-field;
}

&:not([aria-invalid="true"], [aria-disabled="true"]) {
@include borders.border("1px", "solid", "gray-dark");
}

&[aria-disabled="true"] {
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
}
}
Loading
Loading