fix duplicated expense_groups (#653)

* fix duplicated expense_groups * fix expense_objects used
fylein · Jul 23, 2024 · acd341e · acd341e
1 parent a85abca
commit acd341e
Showing 1 changed file with 36 additions and 34 deletions.
diff --git a/apps/fyle/models.py b/apps/fyle/models.py
@@ -405,6 +405,7 @@ def create_expense_groups_by_report_id_fund_source(
         """
 
         expense_groups = []
+        filtered_corporate_credit_card_expense_groups = []
         expense_group_settings = ExpenseGroupSettings.objects.get(
             workspace_id=workspace_id
         )
@@ -440,44 +441,45 @@ def create_expense_groups_by_report_id_fund_source(
             filter(lambda expense: expense.fund_source == "CCC", expense_objects)
         )
 
-        if (
-            general_settings.corporate_credit_card_expenses_object == 'CREDIT CARD PURCHASE' and
-            expense_group_settings.split_expense_grouping == 'MULTIPLE_LINE_ITEM'
-        ):
-            ccc_expenses_without_bank_transaction = [
-                expense for expense in expense_objects
-                if not expense.bank_transaction_id
-            ]
-
-            ccc_expenses_with_bank_transaction = [
-                expense for expense in expense_objects
-                if expense.bank_transaction_id
-            ]
-
-            filtered_corporate_credit_card_expense_groups = _group_expenses(
-                ccc_expenses_without_bank_transaction,
-                corporate_credit_card_expense_group_field,
-                workspace_id,
-            )
+        if corporate_credit_card_expenses:
+            if (
+                general_settings.corporate_credit_card_expenses_object == 'CREDIT CARD PURCHASE' and
+                expense_group_settings.split_expense_grouping == 'MULTIPLE_LINE_ITEM'
+            ):
+                ccc_expenses_without_bank_transaction = [
+                    expense for expense in corporate_credit_card_expenses
+                    if not expense.bank_transaction_id
+                ]
+
+                ccc_expenses_with_bank_transaction = [
+                    expense for expense in corporate_credit_card_expenses
+                    if expense.bank_transaction_id
+                ]
+
+                filtered_corporate_credit_card_expense_groups = _group_expenses(
+                    ccc_expenses_without_bank_transaction,
+                    corporate_credit_card_expense_group_field,
+                    workspace_id,
+                )
 
-            corporate_credit_card_expense_group_field = [
-                field for field in corporate_credit_card_expense_group_field
-                if field not in {'expense_number', 'expense_id'}
-            ]
-            corporate_credit_card_expense_group_field.append('bank_transaction_id')
-            filtered_corporate_credit_card_expense_groups.extend(
-                _group_expenses(
-                    ccc_expenses_with_bank_transaction,
+                corporate_credit_card_expense_group_field = [
+                    field for field in corporate_credit_card_expense_group_field
+                    if field not in {'expense_number', 'expense_id'}
+                ]
+                corporate_credit_card_expense_group_field.append('bank_transaction_id')
+                filtered_corporate_credit_card_expense_groups.extend(
+                    _group_expenses(
+                        ccc_expenses_with_bank_transaction,
+                        corporate_credit_card_expense_group_field,
+                        workspace_id,
+                    )
+                )
+            else:
+                filtered_corporate_credit_card_expense_groups = _group_expenses(
+                    corporate_credit_card_expenses,
                     corporate_credit_card_expense_group_field,
                     workspace_id,
                 )
-            )
-        else:
-            filtered_corporate_credit_card_expense_groups = _group_expenses(
-                corporate_credit_card_expenses,
-                corporate_credit_card_expense_group_field,
-                workspace_id,
-            )
 
         if (
             general_settings.corporate_credit_card_expenses_object == "BILL"