fix duplicated expense_groups #653
Conversation
Hrishabh17
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
WalkthroughThe refactor of the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- apps/fyle/models.py (2 hunks)
Additional comments not posted (9)
apps/fyle/models.py (9)
408-408: Initialization offiltered_corporate_credit_card_expense_groups.The new variable
filtered_corporate_credit_card_expense_groupsis initialized to store grouped expense data. This change is crucial for the subsequent restructuring of the logic.
444-444: Conditional check forcorporate_credit_card_expenses.The restructuring ensures that the grouping logic is executed only when
corporate_credit_card_expensesis present. This prevents unnecessary operations.
445-448: Nested condition forcorporate_credit_card_expenses_objectandsplit_expense_grouping.The nested condition improves readability and ensures that the specific logic for handling corporate credit card expenses is executed only when both conditions are met.
449-452: Segregation of expenses without and with bank transactions.The segregation of
ccc_expenses_without_bank_transactionandccc_expenses_with_bank_transactionallows for a more streamlined approach to processing these expenses.
459-463: Grouping of expenses without bank transactions.The
_group_expensesfunction is called to groupccc_expenses_without_bank_transaction. This ensures that expenses without bank transactions are processed separately.
465-469: Modification ofcorporate_credit_card_expense_group_field.The modification of
corporate_credit_card_expense_group_fieldto excludeexpense_numberandexpense_idand includebank_transaction_idensures that the grouping logic is correctly applied based on the presence of bank transactions.
470-475: Grouping of expenses with bank transactions.The
_group_expensesfunction is called again to groupccc_expenses_with_bank_transaction, ensuring that expenses with bank transactions are processed separately.
477-479: Grouping of corporate credit card expenses.The
_group_expensesfunction is called to groupcorporate_credit_card_expenseswhen the nested condition is not met. This ensures that all corporate credit card expenses are processed.
Line range hint
481-486:
Filtering of grouped corporate credit card expenses.The
filter_expense_groupsfunction is called to filterfiltered_corporate_credit_card_expense_groupsbased on thecorporate_credit_card_expenses_object. This ensures that the filtering logic is correctly applied.
Hrishabh17
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Hrishabh17
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
| expense_group_settings.split_expense_grouping == 'MULTIPLE_LINE_ITEM' | ||
| ): | ||
| ccc_expenses_without_bank_transaction = [ | ||
| expense for expense in corporate_credit_card_expenses |
There was a problem hiding this comment.
changed expense_objects to corporate_credit_card_expenses
| ] | ||
|
|
||
| ccc_expenses_with_bank_transaction = [ | ||
| expense for expense in corporate_credit_card_expenses |
Hrishabh17
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
* fix duplicated expense_groups * fix expense_objects used
Summary by CodeRabbit
Bug Fixes
Refactor