add explicit matrix conversion operators to quat #275
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as you stated in issue #274, adding explicit constructors to matrix types would break the spirit of the library. however this feature can be achieved by adding explicit conversion operators to glm::quat. this way the core profile (the matrix types) remains unpolluted, according to the GLSL standard. so the feature only available if GTC_quaternion extension is used. it is a more C++11 friendly way of type conversion and also preserves the concept of the library.