Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub-menu items not showing up in Bootstrap3 <768px #62

Closed
audreyt opened this issue Aug 22, 2013 · 0 comments
Closed

Sub-menu items not showing up in Bootstrap3 <768px #62

audreyt opened this issue Aug 22, 2013 · 0 comments
Assignees

Comments

@audreyt
Copy link
Member

audreyt commented Aug 22, 2013

It seems Bootstrap 3 Final adjusted menu styles such that all items are by its own row:

2013-08-22 10 16 37

So while the sub-menu from @muan still works in >768px, in "xs" mode (<768px) there are two issues:

  1. In desktop, the hovering drops the right-pointing triangles to the middle (should be top);
  2. Touch-only devices cannot toggle the expansion of sub-menu items at all:

2013-08-22 10 21 57

I wonder if it's easier to reuse Bootstrap 3's $.fn.dropdown for submenus, or adapting something like B3's main menu code is easier.

Custom-coding for this specific fix is good (directly editing index.html to add <script> sections is fine, too). If possible, though, I'd like to see if we can make it into a more generally applicable B3 extension, or adopt one if one exists — that'd be way :cooooooooool: :-)

@ghost ghost assigned muan Aug 22, 2013
muan added a commit that referenced this issue Aug 22, 2013
audreyt added a commit that referenced this issue Aug 22, 2013
Fix submenu for small width (#62)
@audreyt audreyt closed this as completed Aug 22, 2013
muan added a commit that referenced this issue Jan 18, 2014
audreyt added a commit that referenced this issue Jan 18, 2014
Fix submenu for small width (#62)
muan added a commit that referenced this issue Jan 23, 2014
audreyt added a commit that referenced this issue Jan 23, 2014
Fix submenu for small width (#62)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants