Fix submenu for small width (#62) #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, you're fast! Next time feel free to directly commit to the master branch -- you're a committer after all. 👍 |
audreyt
added a commit
that referenced
this pull request
Aug 22, 2013
Fix submenu for small width (#62)
|
Oh, now I see this very helpful "Pull request successfully merged and closed — Delete branch" UI for the very first time! 🆒 That makes the feature-branch workflow much easier, so nvm what I just said about the master branch. 😊 |
|
I am all in the |
way. 😜
audreyt
added a commit
that referenced
this pull request
Jan 18, 2014
Fix submenu for small width (#62)
audreyt
added a commit
that referenced
this pull request
Jan 23, 2014
Fix submenu for small width (#62)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Both are fixed. 2 was cause by
<a>not having href attribute.As for the bootstrap suggestion, I don't see one easily enough to implement. I'd tend to think if there is, it would be included in the official docs. As I previously mentioned, it has been discussed in bootstrap about the reason for dropping support of submenus, and also a suggested method(which is pretty much what we have here.)
So.. still...
