Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting qtimeseries plugin to client core #262

Closed
wants to merge 3 commits into from
Closed

Conversation

volterra79
Copy link
Member

@volterra79 volterra79 added the refactoring Anything which could result in a API change label Nov 15, 2022
@volterra79 volterra79 added this to the v3.9 milestone Nov 15, 2022
@volterra79 volterra79 self-assigned this Nov 15, 2022
@Raruto
Copy link
Collaborator

Raruto commented Jan 12, 2023

For the moment I would wait a little longer before continuing in this direction.

Also in relation to this milestone objectives v3.9:

Move client plugins:

into core g3w-client repository

Because:

  • when you merge everything into a single repository, you easily risk making your code more intricate and bulky
  • when it comes to writing and testing (at all levels), it becomes even more difficult to understand which portion you are actually testing (the test folder will be even more sizeable if you merge everything into one place)
  • those repositories are currently the only ones able to show anyone how to develop a third-party plugin (or start contributing to it more easily).

I know that sometimes it's a bit tedious to develop on multiple repositories, but keep in mind that a project that is too big and "customized" (ie. that doesn't faithfully follow the current "mainsteam" development rules) is very difficult to understand for newcomers...

@volterra79
Copy link
Member Author

@Raruto you can archive it as draft

@Raruto
Copy link
Collaborator

Raruto commented Jan 12, 2023

@volterra79 do you think that temporarily, it might make sense to include them as gitmodules inside the src/plugins folder? (as was the case for some g3w-admin extensions in the past g3w-suite/g3w-admin#368)

In this way I think it would be enough to edit the config.template.js file to ensure that these plugins are always included into the generated bundle:

const G3W_PLUGINS = [ // override "initConfig->group->plugins" attribute for custom plugin development
// "your-plugin-folder-name-1",
// "your-plugin-folder-name-2",
// "your-plugin-folder-name-3",
];

@volterra79
Copy link
Member Author

@Raruto it think we can close it. It better to work with #301

@Raruto
Copy link
Collaborator

Raruto commented Feb 1, 2023

@Raruto it think we can close it. It better to work with #301

Bye #262 👋

@Raruto Raruto closed this Feb 1, 2023
@Raruto Raruto deleted the qtimeseries branch February 1, 2023 13:37
@Raruto Raruto added duplicate This issue or pull request already exists and removed refactoring Anything which could result in a API change labels Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants