-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include default client plugins (editing, qplotly, qtimeseries) as git submodules #301
Conversation
```sh | ||
|
||
git submodules init # to initialize your local configuration file | ||
git submodule update # to fetch all the data from that project and check out the appropriate commit listed in your project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@volterra79 on which git
version did you test the above commands?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Raruto git version 2.17.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've read about different "default" behaviors depending on the installed version, actually mine are:
git version 2.39.0.windows.2 # windows 10
git version 2.34.1 # windows subsystem for linux (ubuntu jammy)
Just to know, have you already updated your git version to the latest available on your OS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Raruto yes. I'm working on Ubuntu 18.04.6 LTS
I feel like we're overcomplicating things here somehow.. (there would also be git-subtrees but I didn't go into details.) At the moment, just to automate some steps, we could think of adding a npm task ( Also because, if you think about it, to generate a coherent bundle for us it would be enough to be sure that all the default
I'll think about it again in the next few days and I'll let you know. |
G3W-SUITE v3.5 already ships the following default plugins:
Through the use of git submodules, this pull just makes sure that related source code is always present in the generated bundle.