Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include default client plugins (editing, qplotly, qtimeseries) as git submodules #301

Closed
wants to merge 2 commits into from

Conversation

volterra79
Copy link
Member

@volterra79 volterra79 commented Jan 13, 2023

G3W-SUITE v3.5 already ships the following default plugins:

  1. editing
  2. qplotly
  3. qtimeseries

Through the use of git submodules, this pull just makes sure that related source code is always present in the generated bundle.

@volterra79 volterra79 added the feature New feature or request label Jan 13, 2023
@volterra79 volterra79 added this to the v3.8 milestone Jan 13, 2023
@volterra79 volterra79 self-assigned this Jan 13, 2023
@Raruto Raruto added dependencies Pull requests that update a dependency file and removed feature New feature or request labels Jan 16, 2023
@Raruto Raruto changed the title Add default plugins with submodules Include default client plugins (editing, qplotly, qtimeseries) as git submodules Jan 16, 2023
config.template.js Outdated Show resolved Hide resolved
```sh

git submodules init # to initialize your local configuration file
git submodule update # to fetch all the data from that project and check out the appropriate commit listed in your project
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@volterra79 on which git version did you test the above commands?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Raruto git version 2.17.1

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've read about different "default" behaviors depending on the installed version, actually mine are:

git version 2.39.0.windows.2 # windows 10
git version 2.34.1           # windows subsystem for linux (ubuntu jammy)

Just to know, have you already updated your git version to the latest available on your OS?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Raruto yes. I'm working on Ubuntu 18.04.6 LTS

@Raruto
Copy link
Collaborator

Raruto commented Jan 16, 2023

I feel like we're overcomplicating things here somehow.. (there would also be git-subtrees but I didn't go into details.)

At the moment, just to automate some steps, we could think of adding a npm task ("preinstall" or "prebuild", I don't know) that takes care of cloning all the necessary plugins and keeping there all these folders as separate repositories.

Also because, if you think about it, to generate a coherent bundle for us it would be enough to be sure that all the default src/plugins/**/plugin.js files are there (and not the entire git repository), i.e.:

  • src/plugins/editing/plugin.js
  • src/plugins/qplotly/plugin.js
  • src/plugins/qtimeseries/plugin.js

I'll think about it again in the next few days and I'll let you know.

@Raruto Raruto added the duplicate This issue or pull request already exists label Feb 16, 2023
@volterra79 volterra79 closed this May 2, 2023
@Raruto Raruto deleted the default-plugins-submodules branch May 8, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants