-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mingw build #2
Comments
I didn't manage to compile at all using mingw (64 bits, g++4.9.1 nuwen.net distribution) It give lots of errors.
|
I didn't find STL's packaged version too useful, can't remember exactly why There are a range of builds here: This worked out of the box with the mods I suggested Note I see he's just added 4.9.2 builds there this week.... Paul |
Just tested with the new 4.9.2 release - looking good! http://sourceforge.net/projects/mingw-w64/files/Toolchains%20targetting%20Win64/Personal%20Builds/mingw-builds/4.9.2/threads-posix/seh/ From latest spdlog git (has a couple of the fixes above already included) In examples dir make all |
Great. So I assume the only thing left before declaring that mingw is supported is to create a new "Makefile.mingw" in example and bench dirs where the -D_WIN32_WINNT flag is set to 0x600.. |
The alternative, to allow building from or targeting of Win XP for visual studio users as well, would be to rework the timezone offset in os.h to use something supported way back when. - I don't know windows APIs so can't help with that. I know a lot of projects where even when dev-ing from more modern machines, they must still target XP and above - hence the furore when Microsoft was late in rolling out an XP targeting pack for newer visual studio release (2012). Personally I'd just stick with your suggestion as supporting very old configurations is difficult at the best of times, besides, my work XP machine is (finally) being upgraded to Win 7 next week :) |
Added Mafile.mingw in example with -D_WIN32_WINNT=0x600 |
Tried to compile the examples with provided makefile.mingw, the one with -D_WIN32_WINNT=0x600 and didn't manage to compile it too.
|
I am not sure. If you manage to fix it, please inform how |
I did originally submit a fix for this, but I don't think mingw is They were a bit clunky (e.g. separate makefile) but I do think it is an Paul On 13 May 2015 at 10:12, zaxthealien notifications@github.com wrote:
|
I tested with mingw 4.9.x 64 bits and it worked fine.. |
I used 32bit version before.
|
nope. still got the same error. |
Merge version 0.11.0 from upstream
The compilation issue with tdm-gcc 4.9.2 and localtime_s related errors could be avoided by adding |
Upgrade spdlog to v1.10.0
Using 4.9.1 mingw64 and building examples
make all in examples dir doesn't find 'makefile'. Recapitalise to 'Makefile' and all OK
details/os.h uses GetDynamicTimeZoneInfo from windows.h
mingw defaults to _WIN32_WINNT=0x502 (XP) so doesn't find this newer api
a) Adjust Makefile to add -D_WIN32_WINNT=0x600 or
b) add logic into os.h to cater for this or adapt to XP targets by using a different API
inline int utc_minutes_offset(const std::tm& tm = localtime())
{
ifdef _WIN32
The text was updated successfully, but these errors were encountered: