-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Catch v3 support #2656
Added Catch v3 support #2656
Conversation
Thanks. I prefer to keep it simpler by just upgrading the bundled version to catch3. If this works with current tests, we can avoid any cmake changes and ifdefs. |
It builds, but the tests fails:
Also catch3 is no longer a header-only library. It need to be compiled first. |
So I think we need to use their recommended approach #2 |
I will update my PR. |
Done. It will use FetchContent() for fetching catch. |
Missing Git on CI. I will add it. |
@xvitaly Sorry, I had to revert this pr, it doens't pass the CI. I realized this only after the merge. Feel free to fix and open new PR. |
#2659 will prevent issues like this from happening in the future. |
Added Catch v3 support with backward compatibility with Catch v2.