Allow BillThirdPartyConsignee to be set in ItemizedPaymentInformation #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store this separately so it can be treated differently than a regular BillThirdParty, as it has to be stored in a different root element in the XML being generated. BillThirdPartyConsignee can be a regular BillThirdParty object
These are only required on the ShipmentCharge, where it is then passed onto the XML creating logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the UPS OnLine® Tools Shipping XML Tool Developers Guide (non-official link) (page 76), the
BillThirdPartyConsigneeelement can be present instead of theBillThirdPartyShipperinside of aItemizedPaymentInformationelement:The purpose of this field is to have a separate
BillThirdPartyinside yourItemizedPaymentInformationthat is not charged for shipping, but (for example) only for duties and taxes (using theSHIPMENT_CHARGE_TYPE_DUTIEStype on theShipmentCharge).In this pull request I've repurposed the main
BillThirdPartyobject to be passed as aBillThirdPartyShipperparameter, as they are identical in terms of fields and methods. I'm open to suggestions to make this more optimal, if needed.