Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow BillThirdPartyConsignee to be set in ItemizedPaymentInformation #343

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Allow BillThirdPartyConsignee to be set in ItemizedPaymentInformation #343

wants to merge 4 commits into from

Commits on Apr 11, 2022

  1. Store additional BillThirdParty for BillThirdPartyConsignee 

    Store this separately so it can be treated differently than a regular
BillThirdParty, as it has to be stored in a different root element in
the XML being generated.

BillThirdPartyConsignee can be a regular BillThirdParty object
    @coenjacobs
    coenjacobs committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    890ccb7 View commit details
    Browse the repository at this point in the history

  2. Write the additional BillThirdParty as BillThirdPartyConsignee element

    @coenjacobs
    coenjacobs committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    a35a0ee View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2022

  1. Strip redundant methods from PaymentInformation 

    These are only required on the ShipmentCharge, where it is then passed
onto the XML creating logic.
    @coenjacobs
    coenjacobs committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    e07dddb View commit details
    Browse the repository at this point in the history

  2. Fix coding standards violations

    @coenjacobs
    coenjacobs committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    5e16315 View commit details
    Browse the repository at this point in the history