fix: wrong word recieveShadow to receiveShadow #1065
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 34.34% // Head: 34.33% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1065 +/- ##
==========================================
- Coverage 34.34% 34.33% -0.02%
==========================================
Files 335 335
Lines 14487 14487
Branches 2221 2221
==========================================
- Hits 4976 4974 -2
Misses 8974 8974
- Partials 537 539 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
感谢！我们已经在0.9 里程碑中重新设计了阴影，详见： #985 |
GuoLei1990
approved these changes
Sep 22, 2022
yangfengzzz
approved these changes
Sep 22, 2022
GuoLei1990
added a commit
to GuoLei1990/galacean-engine
that referenced
this pull request
Oct 17, 2022
* commit 'b391c7441fc934139bf74d997424627b33ea9779': Fix physics lite raycast bug (galacean#999) (galacean#1104) fix: resource parser error (galacean#1105) v0.8.0-beta.31 feat: add release action (galacean#1102) Fix `Compoment`/`Script` `onDisable` and `onEnable` bug (galacean#1087) Revert "fix: onDisable() call back scene is null bug (galacean#1098)" (galacean#1101) fix: onDisable() call back scene is null bug (galacean#1098) Add AnimatorController loader for AniamtorController Editor (galacean#1078) v0.8.0-beta.30 fix: pointer moving delta bug (galacean#1083) v0.8.0-beta.29 fix: texture load bug in miniprogram (galacean#1077) v0.8.0-beta.28 v0.8.0-beta.27 Fix Material Resolved with Texture References (galacean#1076) Support glTF materials remap (galacean#1034) Fix wrong word recieveShadow to receiveShadow (galacean#1065) # Conflicts: # lerna.json # packages/core/package.json # packages/core/src/shadow/Extension.ts # packages/core/src/shadow/ShadowFeature.ts # packages/design/package.json # packages/draco/package.json # packages/loader/package.json # packages/loader/src/index.ts # packages/loader/src/resource-deserialize/index.ts # packages/loader/src/resource-deserialize/resources/animatorController/type.ts # packages/math/package.json # packages/oasis-engine/package.json # packages/physics-lite/package.json # packages/physics-physx/package.json # packages/rhi-webgl/package.json # tests/package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ps： 官方示例文档 中给出的 shadow 示例
cubeRenderer["recieveShadow"] = !castShadow;也需要更改。