Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Material Resolved with Texture References #1076

Merged
merged 46 commits into from
Sep 23, 2022
Merged

Conversation

gz65555
Copy link
Collaborator

@gz65555 gz65555 commented Sep 23, 2022

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

gz65555 and others added 30 commits September 26, 2021 16:32
@codecov-commenter
Copy link

Codecov Report

Base: 34.28% // Head: 34.29% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (7c1cd0f) compared to base (a6ddd00).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1076   +/-   ##
=======================================
  Coverage   34.28%   34.29%           
=======================================
  Files         336      336           
  Lines       14504    14506    +2     
  Branches     2225     2227    +2     
=======================================
+ Hits         4973     4975    +2     
- Misses       8990     8992    +2     
+ Partials      541      539    -2     
Impacted Files Coverage Δ
packages/loader/src/MaterialLoader.ts 2.32% <0.00%> (-0.12%) ⬇️
packages/loader/src/gltf/parser/SceneParser.ts 1.02% <0.00%> (ø)
packages/math/src/Color.ts 89.28% <0.00%> (+3.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GuoLei1990 GuoLei1990 added bug Something isn't working ignore for release ignore for release labels Sep 23, 2022
@GuoLei1990 GuoLei1990 merged commit a09d8bb into galacean:main Sep 23, 2022
GuoLei1990 added a commit to GuoLei1990/galacean-engine that referenced this pull request Oct 17, 2022
* commit 'b391c7441fc934139bf74d997424627b33ea9779':
  Fix physics lite raycast bug (galacean#999) (galacean#1104)
  fix: resource parser error (galacean#1105)
  v0.8.0-beta.31
  feat: add release action (galacean#1102)
  Fix `Compoment`/`Script` `onDisable` and  `onEnable` bug  (galacean#1087)
  Revert "fix: onDisable() call back scene is null bug (galacean#1098)" (galacean#1101)
  fix: onDisable() call back scene is null bug (galacean#1098)
  Add AnimatorController loader  for AniamtorController Editor (galacean#1078)
  v0.8.0-beta.30
  fix: pointer moving delta bug (galacean#1083)
  v0.8.0-beta.29
  fix: texture load bug in miniprogram (galacean#1077)
  v0.8.0-beta.28
  v0.8.0-beta.27
  Fix Material Resolved with Texture References (galacean#1076)
  Support glTF materials remap (galacean#1034)
  Fix wrong word recieveShadow to receiveShadow (galacean#1065)

# Conflicts:
#	lerna.json
#	packages/core/package.json
#	packages/core/src/shadow/Extension.ts
#	packages/core/src/shadow/ShadowFeature.ts
#	packages/design/package.json
#	packages/draco/package.json
#	packages/loader/package.json
#	packages/loader/src/index.ts
#	packages/loader/src/resource-deserialize/index.ts
#	packages/loader/src/resource-deserialize/resources/animatorController/type.ts
#	packages/math/package.json
#	packages/oasis-engine/package.json
#	packages/physics-lite/package.json
#	packages/physics-physx/package.json
#	packages/rhi-webgl/package.json
#	tests/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ignore for release ignore for release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants