Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization shader part of the code #1428

Merged
merged 5 commits into from
Mar 28, 2023

Conversation

cptbtptpbcptdtptp
Copy link
Collaborator

Link: #1394

@cptbtptpbcptdtptp cptbtptpbcptdtptp added the low priority Low priority issue label Mar 24, 2023
@cptbtptpbcptdtptp cptbtptpbcptdtptp added this to the 1.0 milestone Mar 24, 2023
@cptbtptpbcptdtptp cptbtptpbcptdtptp self-assigned this Mar 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2023

Codecov Report

Patch coverage: 63.63% and project coverage change: +0.01 🎉

Comparison is base (74df8aa) 49.26% compared to head (098f23c) 49.27%.

❗ Current head 098f23c differs from pull request most recent head 3df9819. Consider uploading reports for the commit 3df9819 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/1.0    #1428      +/-   ##
===========================================
+ Coverage    49.26%   49.27%   +0.01%     
===========================================
  Files          363      363              
  Lines        18398    18390       -8     
  Branches      2637     2636       -1     
===========================================
- Hits          9063     9062       -1     
+ Misses        8401     8398       -3     
+ Partials       934      930       -4     
Impacted Files Coverage Δ
packages/core/src/2d/sprite/SpriteMask.ts 40.69% <ø> (ø)
packages/core/src/2d/sprite/SpriteRenderer.ts 32.25% <ø> (ø)
packages/core/src/mesh/BlendShapeManager.ts 53.13% <ø> (ø)
packages/core/src/shader/ShaderData.ts 77.48% <ø> (ø)
packages/core/src/shader/ShaderPart.ts 85.71% <0.00%> (ø)
packages/core/src/shader/ShaderProgram.ts 52.08% <ø> (ø)
packages/core/src/ComponentsDependencies.ts 85.29% <60.00%> (+5.80%) ⬆️
packages/core/src/shader/Shader.ts 47.36% <100.00%> (+1.02%) ⬆️
packages/core/src/shader/ShaderPass.ts 75.75% <100.00%> (ø)
packages/core/src/shader/SubShader.ts 66.66% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GuoLei1990 GuoLei1990 added the ignore for release ignore for release label Mar 28, 2023
@GuoLei1990 GuoLei1990 changed the title Clean up part of the code Optimization part of the code Mar 28, 2023
@GuoLei1990 GuoLei1990 changed the title Optimization part of the code Optimization shader part of the code Mar 28, 2023
@GuoLei1990 GuoLei1990 merged commit 3e82284 into galacean:dev/1.0 Mar 28, 2023
GuoLei1990 added a commit to GuoLei1990/galacean-engine that referenced this pull request Mar 28, 2023
…e-asyc-create

* commit '4d5ed09b3ac3cf728fcb63bff0376cc44a4ddaee':
  feat: opt ComponentsDependencies (galacean#1435)
  Optimization shader part of the code (galacean#1428)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release ignore for release low priority Low priority issue
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants