Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixgl.MIN and gl.MAX doesn't exist in webgl1 #1990

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Fixgl.MIN and gl.MAX doesn't exist in webgl1 #1990

merged 3 commits into from
Feb 16, 2024

Conversation

susiwen8
Copy link
Contributor

@susiwen8 susiwen8 commented Jan 31, 2024

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

EXT_blend_minmax
image

@susiwen8 susiwen8 changed the title fix: gl.MIN and gl.MAX doesn't exist in webgl2 fix: gl.MIN and gl.MAX doesn't exist in webgl1 Jan 31, 2024
@GuoLei1990 GuoLei1990 requested a review from zhuxudong February 5, 2024 02:05
@GuoLei1990 GuoLei1990 added the Bug Something isn't working label Feb 5, 2024
@GuoLei1990 GuoLei1990 changed the title fix: gl.MIN and gl.MAX doesn't exist in webgl1 Fixgl.MIN and gl.MAX doesn't exist in webgl1 Feb 5, 2024
Copy link
Member

@GuoLei1990 GuoLei1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If use webGL1.0 with blendMinMax, will thorw error!!!
You should add cap.set(blendMinMax, isWebGL2 || !!requireExtension(blendMinMax)); in GLCapability.ts:

image

@susiwen8
Copy link
Contributor Author

susiwen8 commented Feb 5, 2024

@GuoLei1990 Thanks fot the tip. Fixed

@GuoLei1990 GuoLei1990 added the rendering Rendering related functions label Feb 16, 2024
@GuoLei1990 GuoLei1990 merged commit 065e810 into galacean:main Feb 16, 2024
6 checks passed
@susiwen8 susiwen8 deleted the fix-blendMinMax branch February 17, 2024 13:41
GuoLei1990 added a commit to GuoLei1990/galacean-engine that referenced this pull request Feb 26, 2024
* dev/1.2: (29 commits)
  Add `Preprocessor` in `ShaderLab` (galacean#2009)
  "v1.2.0-alpha.11"
  Add ShaderLab package umd entry (galacean#2006)
  Fix primitive e2e error (galacean#2007)
  "v1.2.0-alpha.10"
  "v1.1.0-beta.49"
  "v1.1.0-beta.48"
  Physics raycast hitResult add shape (galacean#2004)
  Fix output glsl error when `function overload` exists in shaderlab source code (galacean#2001)
  refactor: adapter shadowFadeBorder exported from editor (galacean#1999)
  refactor(render-sort-compare): opt compare code (galacean#2002)
  feat: modify the method of generating the path (galacean#2000)
  "v1.1.0-beta.47"
  Fix`gl.MIN` and `gl.MAX` doesn't exist in `webgl1` (galacean#1990)
  Fix glb/gltf use extension parse (galacean#1992)
  "v1.1.0-beta.46"
  Fix query path error (galacean#1986)
  "v1.1.0-beta.45"
  "v1.1.0-beta.44"
  Fix the problem of resetting `HtmlCanvas.ClientXXX` when call `canvas.resizeByClientSize()` (galacean#1984)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working rendering Rendering related functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants