Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance entity siblingIndex robustness #971

Merged
merged 3 commits into from
Aug 22, 2022
Merged

Conversation

GuoLei1990
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@GuoLei1990 GuoLei1990 added the ignore for release ignore for release label Aug 22, 2022
@GuoLei1990 GuoLei1990 requested a review from gz65555 August 22, 2022 10:36
@codecov-commenter
Copy link

Codecov Report

Merging #971 (a5001f5) into main (b03d75e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #971      +/-   ##
==========================================
+ Coverage   29.88%   29.90%   +0.02%     
==========================================
  Files         333      333              
  Lines       14404    14405       +1     
  Branches     2200     2200              
==========================================
+ Hits         4304     4308       +4     
  Misses       9595     9595              
+ Partials      505      502       -3     
Impacted Files Coverage Δ
packages/core/src/Entity.ts 73.27% <100.00%> (+0.54%) ⬆️
packages/math/src/Color.ts 89.28% <0.00%> (+3.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GuoLei1990 GuoLei1990 merged commit 8b8a572 into galacean:main Aug 22, 2022
@GuoLei1990 GuoLei1990 linked an issue Sep 1, 2022 that may be closed by this pull request
luzhuang pushed a commit to luzhuang/engine that referenced this pull request Sep 6, 2022
GuoLei1990 added a commit to GuoLei1990/galacean-engine that referenced this pull request Sep 9, 2022
…merge-main

* commit 'f7189f1ecf0e2a2a553212bcbc85786fabbcf9bb': (43 commits)
  Fix set font size not valid error (galacean#1019)
  v0.8.0-beta.22
  fix: add protected when material or texture destroy (galacean#1022)
  fix: add protected when material or texture destroy
  Remove Default Timeout for Request (galacean#1021)
  fix Scene load resolve bug (galacean#1018)
  v0.8.0-beta.21
  fix: update Refer in ResourceManager
  v0.8.0-beta.20
  cherry-pick galacean#1003 (galacean#1013)
  refactor: add reflect get property in asset parse (galacean#1003)
  Update .commitlintrc.js
  Update README.md
  types(Transform): fix spell error (galacean#980)
  types(Transform): fix spell error
  v0.8.0-beta.19
  Fix blend shape error (galacean#979)
  v0.8.0-beta.18
  Enhance entity `siblingIndex` robustness (galacean#971)
  fix: `InputManager` keyboard events could not be listened to (galacean#972)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release ignore for release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Switch Entity Index/Add Entity At Index
3 participants