Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fx spell transform error #980

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Fx spell transform error #980

merged 1 commit into from
Aug 29, 2022

Conversation

GuoLei1990
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@GuoLei1990 GuoLei1990 requested review from gz65555 and a team August 29, 2022 04:23
@GuoLei1990 GuoLei1990 added the ignore for release ignore for release label Aug 29, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #980 (97c9576) into main (3a06d38) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #980      +/-   ##
==========================================
- Coverage   29.87%   29.85%   -0.02%     
==========================================
  Files         333      333              
  Lines       14429    14429              
  Branches     2208     2208              
==========================================
- Hits         4310     4308       -2     
+ Misses       9619     9618       -1     
- Partials      500      503       +3     
Impacted Files Coverage Δ
packages/core/src/Transform.ts 22.18% <ø> (ø)
packages/core/src/2d/text/TextRenderer.ts 9.87% <100.00%> (ø)
packages/math/src/Color.ts 85.71% <0.00%> (-7.15%) ⬇️
packages/core/src/DisorderedArray.ts 25.00% <0.00%> (+10.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@cptbtptpbcptdtptp cptbtptpbcptdtptp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@GuoLei1990 GuoLei1990 merged commit b9f2c50 into galacean:main Aug 29, 2022
luzhuang pushed a commit to luzhuang/engine that referenced this pull request Sep 6, 2022
GuoLei1990 added a commit to GuoLei1990/galacean-engine that referenced this pull request Sep 9, 2022
…merge-main

* commit 'f7189f1ecf0e2a2a553212bcbc85786fabbcf9bb': (43 commits)
  Fix set font size not valid error (galacean#1019)
  v0.8.0-beta.22
  fix: add protected when material or texture destroy (galacean#1022)
  fix: add protected when material or texture destroy
  Remove Default Timeout for Request (galacean#1021)
  fix Scene load resolve bug (galacean#1018)
  v0.8.0-beta.21
  fix: update Refer in ResourceManager
  v0.8.0-beta.20
  cherry-pick galacean#1003 (galacean#1013)
  refactor: add reflect get property in asset parse (galacean#1003)
  Update .commitlintrc.js
  Update README.md
  types(Transform): fix spell error (galacean#980)
  types(Transform): fix spell error
  v0.8.0-beta.19
  Fix blend shape error (galacean#979)
  v0.8.0-beta.18
  Enhance entity `siblingIndex` robustness (galacean#971)
  fix: `InputManager` keyboard events could not be listened to (galacean#972)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release ignore for release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants