Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pip at 8.0.0 #9

Merged
merged 3 commits into from
Jan 28, 2016
Merged

Fix pip at 8.0.0 #9

merged 3 commits into from
Jan 28, 2016

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jan 24, 2016

Since pip seems to be evolving rapidly as of recent.
Otherwise we're getting the import errors on new instances.

@mvdbeek
Copy link
Member Author

mvdbeek commented Jan 24, 2016

@natefoo maybe you have a better idea?

@natefoo
Copy link
Member

natefoo commented Jan 25, 2016

--no-index --find-links https://wheels.galaxyproject.org/simple/pip should prevent it from installing a newer pip from PyPI (unless that newer version is already installed). This was discussed on IRC today since that's exactly what the case will always be with Travis. The proposed solution is an "always install Galaxy pip even if it's a 'downgrade'" option, although I think we should probably make this the default as long as --no-replace-pip is not specified.

That said, I am not sure if it's possible with pip if you don't specify the exact version as part of pip install as you've done here, which I would prefer not to do because I want to be able to release bug fixes.

@mvdbeek
Copy link
Member Author

mvdbeek commented Jan 25, 2016

@natefoo yep, this was a workaround for travis ... I was first experimenting with downgrading the installed pip to 7.1.2 prior to running tests, but that didn't work. Perhaps the ansible pip module doesn't respect --no-index ?

@mvdbeek mvdbeek changed the title Fix pip at 8.0.0+gx1 Fix pip at 8.0.0 Jan 25, 2016
@natefoo
Copy link
Member

natefoo commented Jan 26, 2016

Hrm, frustrating, and Ansible hides away the real failure. I believe that version should be 8.0.0+gx1, but hold on a bit, I'm going to make a new 8.0.2+gx1 pip shortly.

@mvdbeek
Copy link
Member Author

mvdbeek commented Jan 26, 2016

Specifying 8.0.0 seems to always catch 8.0.0+gx1, so at least this wouldn't prevent a potential 8.0.0+gx2 to get installed ...

@natefoo
Copy link
Member

natefoo commented Jan 26, 2016

Ah ok, interesting

@natefoo
Copy link
Member

natefoo commented Jan 28, 2016

@mvdbeek Can you update it to 8.0.2? I think we're good to go then. You can also drop --pre from the pip args.

@mvdbeek
Copy link
Member Author

mvdbeek commented Jan 28, 2016

@natefoo done, thanks for looking into this!

@natefoo
Copy link
Member

natefoo commented Jan 28, 2016

Thank you for fixing it!

natefoo added a commit that referenced this pull request Jan 28, 2016
@natefoo natefoo merged commit 6209af5 into galaxyproject:master Jan 28, 2016
@natefoo
Copy link
Member

natefoo commented Jan 29, 2016

Just for the record, this won't be in galaxy.ansible.com until ansible/galaxy-issues#108 is resolved.

@drosofff drosofff deleted the fix_pip_version branch December 18, 2018 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants