[17.09] Fix auth with ldaps:// #4748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abretaud I thought you wanted to target release_17.09? |
|
Oh yes, I forgot about it, I just changed the base branch (and rebased) |
nsoranzo
approved these changes
Oct 4, 2017
|
I don't remember how it works: do I need to make a PR against dev branch too? |
|
@abretaud No, don't worry, it will be merged forward by a committer after the PR is merged. |
|
Awesome thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the python-ldap requirement, the new version allows connecting to ldaps:// now
See galaxyproject/starforge#146 and #3178