-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python-ldap: link against openssl lib to add ldaps:// support #146
Conversation
Thanks @abretaud, much appreciated! |
Thanks @abretaud! I was annoyed by the I also included a reformatting of the prebuild command. Multiline prebuild commands aren't supported but I tested and it's possible to use the yaml folding operator to turn it in to a single line when the yaml is loaded. This should make it a little easier to see changes in the future. For anyone using folding in the future, the command still has to be a valid one line shell command when folded, e.g. this works: for foo in $bar; do
baz &&
quux;
done because it becomes: for foo in $bar; do baz && quux; done but this (valid multiline shell script) does not: for foo in $bar
do
baz
quux
done because it becomes: for foo in $bar do baz quux done |
Cool, thanks! That's much more readable like this! |
Ok, thanks! |
Ok, it was a nightmare of library dependencies and compilation, but I think I managed to write a working recipe. |
Yeah, I'll add lzma support. |
Fingers crossed this should build now if you merge abretaud#3 and rebase or merge master. |
…pile a recent version of openssl)
Green! |
I think that not having SSL support for LDAP can be considered a bug and would approve a PR targeting 17.09. |
I agree with @nsoranzo regarding it being a bug. |
Looks like we're ready to merge finally :) |
Ok, they are uploaded to wheels.galaxyproject.org. Thanks for all your work (and patience) on this @abretaud! |
Here's a patch to (hopefully) fix galaxyproject/galaxy#3178
There was no ldaps:// support in the python-ldap wheel as it was not compiled with openssl support.
I also updated to latest versions.
I tested it on my laptop with some dockers and it seems to work, though I have no way to check if there's the same bug on macosx.
Let's see if it builds here