Refactor upload.py toward reuse #5229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it is a bool.
…it easier to use.
Make decomposing and reuse of this easier downstream and feels cleaner to me.
jmchilton
added
area/upload
kind/refactoring
nsoranzo
reviewed
Dec 18, 2017
| @@ -76,7 +82,7 @@ def add_file(dataset, registry, json_file, output_path): | |||
| line_count = None | |||
| converted_path = None | |||
| stdout = None | |||
| link_data_only = dataset.get('link_data_only', 'copy_files') | |||
| link_data_only = dataset.get('link_data_only', 'copy_files') != 'copy_files' | |||
There was a problem hiding this comment.
I think we should check that the value is in ('link_data_only', 'copy_files').
There was a problem hiding this comment.
I've included this check in #5220 - I'm not sure that PR will make 18.01 so if you believe this is urgent I can backport it into its own PR.
There was a problem hiding this comment.
That's fine for me, thanks @jmchilton!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactorings from #5220 that make uploady.py a little more decomposable, a little more clean, a just a bit more efficient.