Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor upload.py toward reuse #5229

Merged
merged 4 commits into from
Dec 18, 2017
Merged

Refactor upload.py toward reuse #5229

merged 4 commits into from
Dec 18, 2017

Commits on Dec 15, 2017

  1. Upload optimization - eliminate second call to check_binary in upload… 

    ….py.
    @jmchilton
    jmchilton committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    09f51f5 View commit details
    Browse the repository at this point in the history

  2. Upload refactor - make link_data_only a bool. 

    Since it is a bool.
    @jmchilton
    jmchilton committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    cafac19 View commit details
    Browse the repository at this point in the history

  3. Upload refactor - supply reasonable defaults to sniff methods making … 

    …it easier to use.
    @jmchilton
    jmchilton committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    2528ef3 View commit details
    Browse the repository at this point in the history

  4. Upload refactor - change upload.py to use exceptions. 

    Make decomposing and reuse of this easier downstream and feels cleaner to me.
    @jmchilton
    jmchilton committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    7e1bff7 View commit details
    Browse the repository at this point in the history